Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Symfony 7 #24

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat: allow Symfony 7 #24

merged 1 commit into from
Dec 5, 2023

Conversation

KDederichs
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets na
License MIT

What's in this PR?

Allow Symfony 7

Why?

Cause it blocks me from allowing make a PR for Symfony 7 in the HttpPlug Bundle :D

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

@KDederichs
Copy link
Contributor Author

KDederichs commented Dec 4, 2023

@dbu If you could allow the workflow and maybe tag a release I'll see if I can add SF support for the 2.x branch (?) of the HttpPlug bundle as well

@KDederichs
Copy link
Contributor Author

@dbu I added symfony flex to allowed plugins if you could run it again....

@KDederichs
Copy link
Contributor Author

Seems like adding that to the composer config is not enough, looks like it needs to be set globally

@KDederichs
Copy link
Contributor Author

You want me to try and fix the unrelated CI stuff too?

Cause otherwise it's a pass

CHANGELOG.md Outdated Show resolved Hide resolved
@dbu
Copy link
Contributor

dbu commented Dec 5, 2023

thanks a lot!

can you please add the change from #25 into your commit ("symfony/phpunit-bridge": "^6.4.1") . that should fix the lowest version build.

the phpstan issue is a known problem and not related to the changes nor symfony 7.

@KDederichs
Copy link
Contributor Author

thanks a lot!

can you please add the change from #25 into your commit ("symfony/phpunit-bridge": "^6.4.1") . that should fix the lowest version build.

the phpstan issue is a known problem and not related to the changes nor symfony 7.

added it

@dbu dbu merged commit c0c213e into php-http:master Dec 5, 2023
12 of 13 checks passed
@dbu
Copy link
Contributor

dbu commented Dec 5, 2023

released as https://github.com/php-http/stopwatch-plugin/releases/tag/1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants